Infrastructure: Bump eslint from 8.52.0 to 8.57.0, eslint-plugin-jsdoc from 39.3.3 to 48.2.3, eslint-plugin-html from 6.2.0 to 8.1.1, eslint-config-prettier from 8.5.0 to 9.1.0, eslint-plugin-prettier from 4.2.1 to 5.1.3, eslint-plugin-ava from 13.2.0 to 14.0.0, and prettier from 2.7.1 to 3.2.5 #2961
Conversation
… 48.2.0, eslint-plugin-html from 6.2.0 to 8.0.0, and eslint-config-prettier from 8.5.0 to 9.1.0
evmiguel
added
Infrastructure
|
Prettier has been updated. |
evmiguel
changed the title
evmiguel
changed the title
|
Looks like the link checker issue here should be resolved by #2965 |
There was a problem hiding this comment.
Looks good! Thanks for grouping these like-changes together.
Since this makes many changes related to the current formatting, I spent some time looking through the new rules to see where we'd want to preserve the current behavior. I've identified 2 as inline comments. Those 2, not only because they contribute to a significant amount of changes here, which in turns gives an updated file date which isn't substantial - but also because there isn't a clear benefit of enforcing those new formatting changes (to me).
| @@ -24,7 +24,6 @@ function init() { | |||
|
|
|||
| /** | |||
| * Activates the action button with the enter key. | |||
| * | |||
There was a problem hiding this comment.
I think we sould preserve the current way these JSDoc lines are handled by explicitly setting a jsdoc/tag-lines rule.
Setting "jsdoc/tag-lines": ["warn", "any", { "startLines":1 }] in .eslintrc.json rules should be what we want.
test/util/report.js
Outdated
| * <exampleFile>: { | ||
| * existingTestIds: <array of discovered data-test-ids> | ||
| * missingTests: <copy of array of discovered data-test-ids> | ||
| * missingAttrs: <rows in attribute table missing data-test-ids> | ||
| * missingKeys: <rows in keyboard support table missing data-test-ids> | ||
| * } |
There was a problem hiding this comment.
I think we want to allow contributors to preserve their own formatting in JSDoc for instances like this, so readability could be clearer. So disabling jsdoc/check-line-alignment should be fine.
howard-e
changed the title
Supersedes #2943, #2995, #3009, #2891, #2596 and #2929
WAI Preview Link (Last built on Wed, 01 May 2024 14:32:06 GMT).